Merged
Conversation
PlagueCZ
approved these changes
Oct 1, 2024
Contributor
PlagueCZ
left a comment
PlagueCZ
left a comment
There was a problem hiding this comment.
Covers everything needed and more.
Tested in OSC lab and based on Grafana output it is working right.
When dpservice pod gets restarted, exporter is now waiting for gRPC which is absolutely critical for multiport-eswitch due to a bug.
Contributor
|
@vlorinc |
vlorinc
force-pushed
the
fix/exporter_port
branch
from
8646dbe to
6a7eea5
Compare
Implemented a check to verify if TCP port 1337 on localhost is open before attempting to write to the DPDK connection. This ensures more robust error handling and potentially resolves connectivity issues earlier in the process.
- grpc tcp connection is now tested as first step - removed retries of socket connection test, retry is run until success in retryInterval - retryInterval lowered to 5 seconds - update shutdown process: -- when connection to dpdk fails, process ends and doesn't retry the connection -- this way it can be handled by kubernetes and shown in restart counter -- added graceful shutdown of http server - udpate error handling: -- queryTelemetry function now returns error, this error indicates problems with dpdk telemetry socket and shuts down the program -- connection testing functions merged together to clean up code - check for uid to use correct dpdk telemetry socket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
-- when connection to dpdk fails, process ends and doesn't retry to connect as before
-- this way it can be handled by kubernetes and shown in restart counter
-- added graceful shutdown of http server
-- queryTelemetry function now returns error, this error indicates problems with dpdk telemetry socket and shuts down the program
-- connection testing functions merged together to clean up code
Fixes #610 Dpservice crashes due to early telemetry in multiport-eswitch mode:
Metrics are updated only after successful connection to grpc port.