Skip to content

Implement --file-prefix EAL argument for secondary processes#640

Merged
guvenc merged 2 commits intomainfrom
feature/secondary_common
Jan 27, 2025
Merged

Implement --file-prefix EAL argument for secondary processes#640
guvenc merged 2 commits intomainfrom
feature/secondary_common

Conversation

@PlagueCZ
Copy link
Copy Markdown
Contributor

If dpservice is started with --file-prefix then no secondary process can attach anymore as it is still using the default.

This patch simply introduces an argument to the secondary process tools to send the value to EAL.

I also centralized the handling of EAL arguments for secondary processes.

@github-actions github-actions bot added size/L bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 21, 2025
@PlagueCZ PlagueCZ force-pushed the feature/secondary_common branch from 618d50c to 243bae6 Compare January 24, 2025 16:21
@PlagueCZ PlagueCZ requested a review from guvenc January 24, 2025 16:40
@PlagueCZ PlagueCZ marked this pull request as ready for review January 24, 2025 16:40
@PlagueCZ PlagueCZ requested a review from a team as a code owner January 24, 2025 16:40
@guvenc
Copy link
Copy Markdown
Contributor

guvenc commented Jan 27, 2025

@PlagueCZ
Could you please rebase to main ? I was forced to push a github action related commit to main without a PR to fix a github ARM build failure which is only visible on main branch and doesnt change any functionality of the codebase. (github updated the runners to ubuntu 24.04 when using ubuntu-latest in the action which broke our ARM build)

@PlagueCZ PlagueCZ force-pushed the feature/secondary_common branch from 243bae6 to d80bc5a Compare January 27, 2025 11:40
Copy link
Copy Markdown
Contributor

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested shortly. LGTM

@guvenc guvenc merged commit d80bc5a into main Jan 27, 2025
@guvenc guvenc deleted the feature/secondary_common branch January 27, 2025 12:45
@guvenc guvenc linked an issue Jan 29, 2025 that may be closed by this pull request
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request size/L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve secondary process infrastructure in dpservice

3 participants