Helper environment variables for tools in container#652
Merged
Conversation
github-actions
bot
added
documentation
PlagueCZ
force-pushed
the
feature/helper_env_vars
branch
from
41a09d0 to
65d7af3
Compare
Contributor
|
@PlagueCZ Please rebase. Thanks ! |
PlagueCZ
force-pushed
the
feature/helper_env_vars
branch
from
65d7af3 to
0f2fc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous commit(s) introduced the ability to specify a different gRPC port and DPDK file-prefix for all tools.
But when dpservice is ran as a pod, these values are defined in the YAML. It is then a usability hurdle to specify these on the command line all the time while using dpservice tooling.
This PR simply creates environment variables that can be set from the pod YAML.