Merged
Conversation
github-actions
bot
added
documentation
PlagueCZ
force-pushed
the
feature/dpservice_ha
branch
from
828324f to
3d665ed
Compare
PlagueCZ
force-pushed
the
feature/dpservice_ha
branch
from
3d665ed to
1b99d51
Compare
Contributor
Author
|
This is now running in OSC on multiple clusters and seems to be working fine. I suggest looking at the commits of this PR separately as the are actually simple changes, just overly verbose due to the nature of what has been changed. For example for the gRPC protocol change, you can always see 6 blocks of changes (changed 6 calls), but in many places. Also pre-DPDK-23.11.3 commit, everything is also working (except the number of VMs) so that can also simplify the review process if you look at that part separately. |
byteocean
reviewed
Mar 31, 2025
Contributor
|
I am able to successfully run the tests after applying all patches to DPDK on a server. |
PlagueCZ
force-pushed
the
feature/dpservice_ha
branch
from
b3d10b6 to
6602ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to run parallel dpservices (both with separate hugepage area) where only one is ever the active one, the others are standing by (ensured by a
flock()on a common file).To properly orchestrate them so both have the same configuration, underlay address generation needs to be externally (in OSC by two metalnets), which is now supported (but optional) in gRPC protocol.
The last thing is a changed Mellanox/DPDK configuration to not create a default rule, which needlessly duplicates packets when two instances are running. This was previously possible by just changing the configuration of PF0, now also a DPDK patch is needed (see #643).
Fixes #643
Of course without metalnet logic changes, proper HA is not possible, but all needed changes to dpservice are done.