dpservice-cli: fix for pytest unable to detect errors#657
Merged
Conversation
PlagueCZ
reviewed
Mar 19, 2025
Contributor
PlagueCZ
left a comment
PlagueCZ
left a comment
There was a problem hiding this comment.
This seems to work really well, the new approach is better. But I was part of the change, so we need a fresh a pair of eyes now.
all errors returned to main are parsed and rendered based on output flag e.g. if json output was requested error will also be shown as json Update pytest to latest dpservice-cli changes, add tests for error responses improved error parsing and error source is now generated automatically fix return value in ListNats function
vlorinc
force-pushed
the
dpservice-cli/fix-pytest
branch
from
eb2e512 to
4d94cff
Compare
guvenc
approved these changes
Mar 25, 2025
Contributor
guvenc
left a comment
guvenc
left a comment
There was a problem hiding this comment.
LGTM. I also liked the fact that we added some tests which would catch if the errors get ignored in a similar way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #650