Merged
Conversation
Contributor
|
PLease rebase to main. Thanks ! |
PlagueCZ
force-pushed
the
feature/simplify_virtsvc_isolation
branch
from
dde3121 to
e884d98
Compare
PlagueCZ
force-pushed
the
feature/simplify_virtsvc_isolation
branch
from
e884d98 to
2e1f0ae
Compare
byteocean
approved these changes
May 6, 2025
Contributor
byteocean
left a comment
byteocean
left a comment
There was a problem hiding this comment.
LGTM. But I do not get the statement "...makes the codebase read for a situation when the validation is re-introduced". Does it mean 'the codebase ready and working when the validation is enabled again'?
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #672
This change is not necessary due to the removal of validation in PR #672, but makes the codebase read for a situation when the validation is re-introduced.
Also this simpler implementation is actually functionally equivalent to the previous one.
Fixes #671