Remove pytest packet noise, fix HW test side-effects#682
Merged
Conversation
byteocean
approved these changes
Jun 5, 2025
Contributor
byteocean
left a comment
byteocean
left a comment
There was a problem hiding this comment.
localtests and benchmarktests still work. LGTM.
PlagueCZ
force-pushed
the
fix/pytest_packet_noise
branch
from
4737294 to
fa019b7
Compare
guvenc
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using
--graphtracein dpservice PyTest suite, I noticed I am getting unwanted packets:This seems to be some IPv6 autoconfiguration/nd stuff. But when testing we do not even need the kernel IPv6 stack, so the best solution seemed to be just disabling it altogether.
That would of course break your host configuration in real HW tests, so I changed the code to only do it for TAP devices. This also fixed an old bug where HW tests removed the IPv6 address from the real HW card.