Conversation
byteocean
approved these changes
Jun 5, 2025
Contributor
byteocean
left a comment
byteocean
left a comment
There was a problem hiding this comment.
thanks for taking care of this rollback. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a check missing after allocation.
I also added a "rollback", though in that case I don't think there is any hope for recovery.
The rollback is now also done if cannot be added to a hash table, which actually can easily happen if it gets full, so please check that such rollback actually helps and not makes things worse.
While reading the code I did some simplifications too.