Skip to content

Add missing frees in argument parsing#685

Merged
guvenc merged 1 commit intomainfrom
fix/opts_frees
Jun 6, 2025
Merged

Add missing frees in argument parsing#685
guvenc merged 1 commit intomainfrom
fix/opts_frees

Conversation

@PlagueCZ
Copy link
Copy Markdown
Contributor

@PlagueCZ PlagueCZ commented Jun 3, 2025

There were some edge cases where freeing of command-line argument memory was not properly done.

No real-world implication as this is just before the process exits anyway.

  • DHCPv6 DNS options were never freed
  • if dp_service.conf contains some options that allocate memory, then before actual command-line parsing the process fails, that memory would never be freed
  • if one mellanox option (in the config fileú does not properly allocate, the other mellanox options would not get freed

@PlagueCZ PlagueCZ requested a review from a team as a code owner June 3, 2025 22:37
@github-actions github-actions bot added size/S bug Something isn't working labels Jun 3, 2025
@guvenc guvenc linked an issue Jun 4, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@byteocean byteocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing.

@PlagueCZ PlagueCZ force-pushed the fix/opts_frees branch 2 times, most recently from f7c3235 to 09bdbb2 Compare June 6, 2025 14:43
@guvenc
Copy link
Copy Markdown
Contributor

guvenc commented Jun 6, 2025

@PlagueCZ would you please rebase ?

@guvenc guvenc merged commit b0ecec6 into main Jun 6, 2025
6 checks passed
@guvenc guvenc deleted the fix/opts_frees branch June 6, 2025 18:19
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking bug Something isn't working size/S

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix several missing memory frees

4 participants