Log which loadbalancer already exists when adding fails #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@PlagueCZ Could you please rebase to main ? |
PlagueCZ
force-pushed
the
feature/duplicate_lb_warning
branch
from
ca8f1d1 to
0b8d6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If adding a loadbalancer fails with ALREADY_EXISTS, it would be nice to know what is the ID of the existing LB, makes it easier to investigate.
Of course this information already is in some objects, but since we are already doing a hashtable lookup, this is basically free information and it does make operations easier.
Issue #736