Adapt prepare script for a machine with two Nics#757
Merged
Conversation
PlagueCZ
approved these changes
Mar 8, 2026
Contributor
PlagueCZ
left a comment
PlagueCZ
left a comment
There was a problem hiding this comment.
I tested on my local machine and on two of our clusters, the resulting config has empty diff.
We however now completely disable the other mellanox card, so I cannot test that state anymore (not easily anyway).
Given the fact that this change would not be able to address that situation, I would consider this PR tested and compatible.
byteocean
force-pushed
the
enh/prepare-two-nic
branch
from
38f7264 to
5c6bbce
Compare
byteocean
force-pushed
the
enh/prepare-two-nic
branch
from
5c6bbce to
33ceca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #756.
More generally speaking, the script works for a machine equipped with one mellanox card and one non-mellanox card.