Conversation
byteocean
approved these changes
Mar 23, 2026
|
|
||
| // ARP reply from VM | ||
| if (unlikely(sender_ip == htonl(port->iface.cfg.own_ip))) { | ||
| if (unlikely(dp_arp_cycle_needed(port) && sender_ip == htonl(port->iface.cfg.own_ip))) { |
Contributor
There was a problem hiding this comment.
if we want to update MAC address cache even if VM suddenly changes it during running, we can also do
if (sender_ip == htonl(port->iface.cfg.own_ip)) {
dp_l2_addr_set(port, &incoming_eth_hdr->src_addr);
port->iface.arp_done = true; // stop further probing
// fall through — don't consume
}
But they are different approaches with very minor difference, so the change in this PR should be sufficient now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix of a fix from #769 which introduced a bug in ARP which degraded performace. Network wos working but with occasional packet loss, that is why previous tests missed it.
I simply fully reverted the garp implementation to before #714, the rest of #769, i.e. DHCP and ND is kept.
Fixes #768