Skip to content

Conversation

@ushabelgur
Copy link
Contributor

Proposed Changes

  • As common MachinePool is being used across all controller package testcases, sometime MachineClasses attached to the pool are not yet deleted and we are doing equal comparison of list of resources, which is causing test case to fail sometimes.
  • Instead of equal added contains check to see if MachinePool contains newly created MachineClasses with expected quantity

Fixes #1323

@ushabelgur ushabelgur requested a review from a team as a code owner July 16, 2025 13:19
@github-actions github-actions bot added bug Something isn't working size/M labels Jul 16, 2025
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/fix_machinepoollet_tests branch from 5cf18f0 to f7a0ac5 Compare July 16, 2025 13:19
@ushabelgur
Copy link
Contributor Author

I see some other tests failing after fixing machinePoollet related tests
Like this https://github.com/ironcore-dev/ironcore/actions/runs/16320623702/job/46097150773?pr=1330 and
this https://github.com/ironcore-dev/ironcore/actions/runs/16335652712/job/46147139835?pr=1330
Should fix them as well

@lukasfrank lukasfrank marked this pull request as draft July 17, 2025 05:55
@Rohit-0505
Copy link
Contributor

@ushabelgur
Copy link
Contributor Author

I see some other tests failing after fixing machinePoollet related tests Like this https://github.com/ironcore-dev/ironcore/actions/runs/16320623702/job/46097150773?pr=1330 and this https://github.com/ironcore-dev/ironcore/actions/runs/16335652712/job/46147139835?pr=1330 Should fix them as well

You may have a look at this test also https://github.com/ironcore-dev/ironcore/actions/runs/16337620897/job/46152743268?pr=1333

@lukas016 can we open separate PR for other sporadic test failures, may be we can close this one

@ushabelgur ushabelgur marked this pull request as ready for review July 17, 2025 07:00
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jul 17, 2025
@hardikdr hardikdr added this to Roadmap Jul 17, 2025
@afritzler afritzler changed the title Fix machinepoolet flaky tests Fix sporadic test failures in machinepoollet test suite Jul 18, 2025
@afritzler afritzler merged commit 72224a9 into ironcore-dev:main Jul 18, 2025
14 of 16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/iaas Issues related to IronCore IaaS development. bug Something isn't working size/M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Flaky tests

4 participants