Skip to content

Added Terminating & Terminated machine state #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasfrank merged 3 commits into from
Feb 13, 2024
Merged

Added Terminating & Terminated machine state #169

lukasfrank merged 3 commits into from
Feb 13, 2024

Conversation

@lukas016
Copy link
Contributor

@lukas016 lukas016 commented Feb 9, 2024 •
edited by lukasfrank
Loading

Proposed Changes

  • Implement terminating state
  • Implement terminated state
  • Report blocked state as pending

Fixes #158

@lukas016
improve machine state processing
d86b2de 
- implement terminating state
- implement terminated state
- report blocked state as pending
@lukas016 lukas016 linked an issue Feb 9, 2024 that may be closed by this pull request
Implement Terminating machine state #158
Closed
@lukas016 lukas016 marked this pull request as ready for review February 9, 2024 10:17
@lukas016 lukas016 requested a review from a team as a code owner February 9, 2024 10:17
@lukas016 lukas016 self-assigned this Feb 9, 2024
lukasfrank
lukasfrank reviewed Feb 12, 2024
View reviewed changes
lukasfrank
lukasfrank previously approved these changes Feb 12, 2024
View reviewed changes
@lukasfrank lukasfrank added the integration-tests to run integration tests label Feb 12, 2024
@afritzler
Copy link
Member

afritzler commented Feb 12, 2024

Can we have a more meaningful PR title like: Add Terminating state handling

@lukas016
Copy link
Contributor Author

lukas016 commented Feb 12, 2024

Can we have a more meaningful PR title like: Add Terminating state handling

yes, but technically i added more states

@lukasfrank lukasfrank changed the title improve machine state processing Added Terminating & Terminated machine state Feb 12, 2024
so-sahu
so-sahu reviewed Feb 12, 2024
View reviewed changes
so-sahu
so-sahu approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@so-sahu so-sahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasfrank lukasfrank merged commit 0e7db86 into main Feb 13, 2024
@lukasfrank lukasfrank deleted the 158-implement-terminating-machine-state branch February 13, 2024 07:13
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
@hardikdr hardikdr moved this to Done in Roadmap Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@so-sahu so-sahu so-sahu approved these changes

@lukasfrank lukasfrank lukasfrank left review comments

Assignees

@lukas016 lukas016

Labels

area/compute controllers integration-tests to run integration tests server size/M

Projects

Compute
Archived in project
Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Terminating machine state

6 participants

@lukas016 @afritzler @lukasfrank @so-sahu @hardikdr