Skip to content

Remove CGO build flag#698

Merged
friegger merged 7 commits intomainfrom
chore/remove-cgo-build-flag
Apr 22, 2026
Merged

Remove CGO build flag#698
friegger merged 7 commits intomainfrom
chore/remove-cgo-build-flag

Conversation

@friegger
Copy link
Copy Markdown
Contributor

@friegger friegger commented Mar 17, 2026

CGO is not required anymore.

This fixes also a problem with the recent release drafter bump.

Summary by CodeRabbit

  • Chores
    • Simplified release automation by adjusting workflow triggers and conditional steps for PRs, pushes, and manual dispatches.
    • Standardized build and lint invocations by removing explicit environment overrides, relying on tool defaults for more consistent builds.

@friegger friegger requested a review from a team as a code owner March 17, 2026 12:00
@friegger friegger requested a review from lukasfrank March 17, 2026 12:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2dd4860f-9d0a-47e7-aa56-ab341994b6cf

📥 Commits

Reviewing files that changed from the base of the PR and between c04d365 and 34b02bf.

📒 Files selected for processing (1)
  • Dockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile

📝 Walkthrough

Walkthrough

Replaced workflow trigger pull_request_targetpull_request, added a gate so one drafter step runs only on push or workflow_dispatch, and removed explicit CGO environment overrides from Go build/lint invocations in Dockerfile and Makefile.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/release-drafter.yml
Changed on trigger from pull_request_target to pull_request. Updated autolabeler condition to github.event_name == 'pull_request'. Added condition so the second drafter step runs only when github.event_name is push or workflow_dispatch.
Build & Lint Commands
Dockerfile, Makefile
Removed explicit CGO_ENABLED environment settings: dropped CGO_ENABLED=0 from go build/go install in Dockerfile, and removed CGO_ENABLED=1 prefixes from Makefile targets (lint, lint-fix, build).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • gonzolino
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete compared to the required template; it lacks the 'Proposed Changes' section with bullet points and the 'Fixes #' reference required by the template. Add a 'Proposed Changes' section with bullet points describing each change (removing CGO from Dockerfile, Makefile, and workflow fix) and include the 'Fixes #' issue reference.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove CGO build flag' directly and specifically describes the main change in the changeset, which is removing CGO environment variables from the build configuration across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-cgo-build-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@friegger friegger enabled auto-merge (squash) April 22, 2026 13:02
@friegger friegger merged commit 45e55ce into main Apr 22, 2026
10 checks passed
@friegger friegger deleted the chore/remove-cgo-build-flag branch April 22, 2026 13:06
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants