Move RedFish mock methods to the go mock server#508
Merged
Conversation
nagadeesh-nagaraja
requested review from
Nuckal777,
afritzler,
defo89 and
stefanhipfel
nagadeesh-nagaraja
force-pushed
the
EnhanceMockServer
branch
4 times, most recently
from
0320563 to
478e5da
Compare
nagadeesh-nagaraja
force-pushed
the
EnhanceMockServer
branch
from
478e5da to
750850d
Compare
afritzler
changed the title
Member
|
@nagadeesh-nagaraja can you please rebase this PR? |
nagadeesh-nagaraja
force-pushed
the
EnhanceMockServer
branch
from
ccbd181 to
dad5c60
Compare
afritzler
requested changes
Nov 11, 2025
nagadeesh-nagaraja
force-pushed
the
EnhanceMockServer
branch
from
da39c4c to
bb5f4d9
Compare
afritzler
requested changes
Nov 12, 2025
afritzler
requested changes
Nov 12, 2025
internal/controller/suite_test.go
Outdated
| mockServer := server.NewMockServer(GinkgoLogr, ":8000") | ||
| if err := mockServer.Start(ctx); err != nil { | ||
| return fmt.Errorf("failed to start mock Redfish server: %w", err) | ||
| DeferCleanup(cancel) |
Member
There was a problem hiding this comment.
DeferCleanup(cancel) is happening already at the top of the BeforeSuite.
nagadeesh-nagaraja
force-pushed
the
EnhanceMockServer
branch
from
c404d03 to
53f721a
Compare
afritzler
approved these changes
Nov 12, 2025
afritzler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507