Fix updating status in biosSettings and server CRD state transition#533
Merged
Fix updating status in biosSettings and server CRD state transition#533
Conversation
nagadeesh-nagaraja
force-pushed
the
impreovement
branch
from
036b12b to
330219a
Compare
| } | ||
| })).Should(Succeed()) | ||
|
|
||
| Eventually(Object(bmcVersion)).Should( |
Contributor
Author
There was a problem hiding this comment.
This is causing flakiness as the state changes to Completed very quickly... depending on at which point in time the resource state was put to failed during the test.
| }, | ||
| } | ||
| // we wait for the server to be created first and the then deleted | ||
| Eventually(Get(server)).Should(Succeed()) |
Contributor
Author
There was a problem hiding this comment.
make sure the server is deleted after its been created. else will cause unit test issues if we delete this before it was created and rest of the unit test will fail to have clean state.
nagadeesh-nagaraja
changed the title
nagadeesh-nagaraja
changed the title
Nuckal777
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
make sure to update the status fields before moving the state of Server CRD by not allowing to move to Maintenance or reserved before Discovery State,
make sure to move to failed to state when the Flow state Fails in biosSettings CRD