Conversation
| BIOSVersionFinalizer = "metal.ironcore.dev/biosversion" | ||
| biosVersionUpgradeIssued = "BIOSVersionUpgradeIssued" | ||
| biosVersionUpgradeCompleted = "BIOSVersionUpgradeCompleted" | ||
| biosVersionUpgradeRebootServerPowerOn = "BIOSVersionUpgradePowerOn" | ||
| biosVersionUpgradeRebootServerPowerOff = "BIOSVersionUpgradePowerOff" | ||
| biosVersionUpgradeVerficationCondition = "BIOSVersionUpgradeVerification" | ||
| biosVersionFinalizer = "metal.ironcore.dev/biosversion" | ||
| biosVersionUpgradeIssued = "BIOSVersionUpgradeIssued" | ||
| biosVersionUpgradeCompleted = "BIOSVersionUpgradeCompleted" | ||
| biosVersionUpgradeRebootServerPowerOn = "BIOSVersionUpgradePowerOn" | ||
| biosVersionUpgradeRebootServerPowerOff = "BIOSVersionUpgradePowerOff" | ||
| biosVersionUpgradeVerificationCondition = "BIOSVersionUpgradeVerification" | ||
| biosUpgradeIssuedReason = "UpgradeIssued" | ||
| biosUpgradeIssueReason = "IssueBIOSUpgradeFailed" | ||
| rebootPowerOffReason = "RebootPowerOff" | ||
| rebootPowerOnReason = "RebootPowerOn" | ||
| biosVersionVerifiedReason = "VerifiedBIOSVersionUpdate" | ||
| biosVersionVerifyReason = "VerifyBIOSVersionUpdate" | ||
| biosUpgradeTaskFailedReason = "BiosUpgradeTaskFailed" | ||
| biosVersionUpgradeTaskCompletedReason = "taskCompleted" |
There was a problem hiding this comment.
@nagadeesh-nagaraja we need to rework the condition reasons and types here to have a more homogeneous experience. I just factored out the constants here for the moment.
There was a problem hiding this comment.
Yes, we need to.
we had discussed this in one of the meeting on thrusdays..
i took up for one of the controllers here: https://github.com/ironcore-dev/metal-operator/pull/547/files
I thought the agreed format was
BIOSVersionCondition ?
that is what I did for BIOSSettings.
if we are going with Conditions<task/type>, Reason<task/type>, I am okay with that as well. but we might just have done some duplicate work :D
There was a problem hiding this comment.
I updated the conditions and reasons for the BIOSVersion reconciler.
afritzler
force-pushed
the
enh/biosversion
branch
from
a0dc77e to
81d28e4
Compare
4 participants
Proposed Changes
BIOSVersionreconciler