Conversation
github-actions
bot
added
size/XXL
api-change
documentation
afritzler
force-pushed
the
enh/biossettings
branch
from
644af96 to
88885b8
Compare
Nuckal777
requested changes
Dec 9, 2025
Contributor
Nuckal777
left a comment
Nuckal777
left a comment
There was a problem hiding this comment.
Thanks, just some nitpicks.
| for _, settings := range biosSettings.Spec.SettingsFlow { | ||
|
|
||
| duplicateName := make([]string, 0, len(settings.Spec.SettingsFlow)) | ||
| duplicateSettingsNames := make([]string, 0, len(settings.Spec.SettingsFlow)) |
Contributor
There was a problem hiding this comment.
The given capacity here makes no sense. The map tracks settings, which a part of a single flow item.
| server *metalv1alpha1.Server, | ||
| ) (pendingSettings redfish.SettingsAttributes, err error) { | ||
| pendingSettings, err = bmcClient.GetBiosPendingAttributeValues(ctx, server.Spec.SystemURI) | ||
| pendingSettings, err := bmcClient.GetBiosPendingAttributeValues(ctx, server.Spec.SystemURI) |
Contributor
There was a problem hiding this comment.
Could the result of this function call be returned directly?
Comment on lines
+871
to
+873
| if len(pendingSettingsDiff) > 0 { | ||
| log.V(1).Info("Difference between the pending settings and that of required", "SettingsDiff", pendingSettingsDiff) | ||
| } |
Contributor
There was a problem hiding this comment.
The same check and log line happen 5 lines below. Please deduplicate.
Nuckal777
reviewed
Dec 9, 2025
Comment on lines
1061
to
1063
| func (r *BIOSSettingsReconciler) isServerInMaintenance(log logr.Logger, settings *metalv1alpha1.BIOSSettings, server *metalv1alpha1.Server) bool { | ||
| if settings.Spec.ServerMaintenanceRef == nil { | ||
| return true |
Contributor
There was a problem hiding this comment.
Assuming that the absence of a maintenance ref means that the server is in maintenance looks suspicious.
Member
Author
There was a problem hiding this comment.
Uhm yeah 🦭 I guess when the ref is nil that means false.
Member
Author
|
Thanks @Nuckal777 for the review! I addressed the issues mentioned above. |
afritzler
force-pushed
the
enh/biossettings
branch
from
995faf3 to
b1a3a93
Compare
afritzler
force-pushed
the
enh/biossettings
branch
from
b1a3a93 to
176d396
Compare
Nuckal777
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
BIOSSettingsreconciler