Use constants for mock server addresses and port in unit tests

[xkonni]

in #581 the variables MockServerIP and MockServerPort of a _test.go file were moved into the corresponding suite_test.go file for that package, this PR updates all other tests to do the same.

Summary by CodeRabbit

• Tests
  • Standardized test configuration by replacing hard-coded server addresses with reusable mock constants across multiple test suites, improving test maintainability and consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Introduces three new mock constants (MockServerIP, MockServerIP2, MockServerPort) in the move package and replaces hard-coded IP address and port literals across twelve controller test files and one move test file with these constants for consistency and maintainability.

Changes

Cohort / File(s)	Summary
Mock Constants Definition internal/cmd/move/suite_test.go	Adds three new public constants: MockServerIP ("127.0.0.1"), MockServerIP2 ("127.0.0.2"), and MockServerPort (8000) to the move package.
Move Package Tests internal/cmd/move/move_test.go	Replaces hard-coded IP literals (127.0.0.1, 127.0.0.2) with MockServerIP and MockServerIP2 constants in EndpointSpec initializations.
Controller Tests (Endpoint/Server Configuration) internal/controller/endpoint_controller_test.go, internal/controller/server_controller_test.go, internal/controller/serverclaim_controller_test.go, internal/controller/servermaintenance_controller_test.go	Replaces hard-coded values (127.0.0.1 → MockServerIP, 8000 → MockServerPort) in BMCAccess and Endpoint specifications across multiple test scenarios.
Controller Tests (Dynamic Address Construction) internal/controller/biossettingsset_controller_test.go, internal/controller/biosversionset_controller_test.go, internal/controller/bmcversionset_controller_test.go	Replaces hard-coded IP:port string literals with dynamic construction using fmt.Sprintf("%s:%d", MockServerIP, MockServerPort ± offset) in MockServerIPAddrs initialization. Adds fmt import.
Controller Tests (BIOS/BMC Configuration) internal/controller/biosversion_controller_test.go, internal/controller/bmc_controller_test.go, internal/controller/bmcsettings_controller_test.go, internal/controller/bmcversion_controller_test.go	Replaces hard-coded IP and port values (127.0.0.1 → MockServerIP, 8000 → MockServerPort) in InlineEndpoint IP fields, Status.IP assertions, and Protocol.Port configurations across multiple BMC and BIOS test cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

area/metal-automation, size/XL

Suggested reviewers

• Nuckal777

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description is concise and explains the context and purpose clearly, referencing PR#581 and stating the objective of updating all other tests.
Title check	✅ Passed	The title accurately reflects the main objective: replacing hard-coded IP and port literals with mock server constants across unit tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}