Add missing roles to rbac kustomization

[asergeant01]

Proposed Changes

Some rbacs were not added to the customisation.yaml previously

Summary by CodeRabbit

• New Features

  • Expanded RBAC coverage with admin/editor/viewer roles for many additional resource types (bmc, bmcsecret, bios, endpoint, server, serverbootconfiguration, serverclaim, servermaintenance, and others).

• Chores

  • Consolidated and consistently indented RBAC manifest entries into a single active list, removing duplicated comment blocks and enabling the referenced RBAC resources for installation.

[coderabbitai]

Walkthrough

Rewrote config/rbac/kustomization.yaml to replace commented/misaligned entries with a single, consistently indented YAML resources list, activating and expanding the RBAC resource references to include many per-CRD Admin/Editor/Viewer role files.

Changes

Cohort / File(s)

Summary

RBAC kustomization config/rbac/kustomization.yaml

Reformatted resources into a consistent YAML list and expanded the referenced RBAC files. Converted previously commented or dash-prefixed lines into active - <file> entries, adding numerous per-CRD role files (e.g., biossettings*, biossettingsset*, biosversion*, biosversionset*, bmc*, bmcsecret*, bmcsettings*, bmcsettingsset*, bmcuser*, bmcversion*, bmcversionset*, endpoint*, server*, serverbootconfiguration*, serverclaim*, servermaintenance* admin/editor/viewer roles) while preserving original ordering semantics and comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete, missing the bulleted list of proposed changes required by the template.	Expand the description to include bullet points detailing the specific RBAC roles being added and why they were missing.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: adding missing RBAC roles to the kustomization file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/add-missing-rbacs-to-kustomize.yaml

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@config/rbac/kustomization.yaml`:
- Around line 34-36: The kustomization.yaml contains duplicate resource entries
for bmcsettingsset_admin_role.yaml, bmcsettingsset_editor_role.yaml, and
bmcsettingsset_viewer_role.yaml (they appear twice); remove the second set of
duplicates so each of bmcsettingsset_admin_role.yaml,
bmcsettingsset_editor_role.yaml, and bmcsettingsset_viewer_role.yaml only
appears once in the resources list (keep the first occurrence and delete the
repeated entries), ensuring the resources block in kustomization.yaml no longer
contains duplicated filenames.

🧹 Nitpick comments (1)

config/rbac/kustomization.yaml (1)

21-24: Redundant scaffolding comment blocks and stale template placeholder.

The same "Admin/Editor/Viewer" scaffolding comment is repeated three times (lines 21–24, 50–53, 58–61). Two of them still contain the un-rendered {{ .ProjectName }} placeholder. Consider keeping a single comment block (using the concrete project name) above all the CRD role entries.

Also applies to: 50-53, 58-61

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@config/rbac/kustomization.yaml`:
- Around line 25-69: The kustomization list is missing three RBAC role entries;
add bmcsettingsset_admin_role.yaml, bmcsettingsset_editor_role.yaml, and
bmcsettingsset_viewer_role.yaml into the resources block (the same list that
contains bmcsettings_admin_role.yaml and bmcsettings_viewer_role.yaml) and place
them in alphabetical order among the CRD role entries so they appear alongside
the other *_admin_role.yaml, *_editor_role.yaml, and *_viewer_role.yaml entries.