Allow deletion of the ServerClaim when Server does not exist#70
Merged
Allow deletion of the ServerClaim when Server does not exist#70
ServerClaim when Server does not exist#70Conversation
hardikdr
force-pushed
the
fix/allow-deleting-serverclaim
branch
from
255e7c7 to
15cffec
Compare
afritzler
requested changes
Jul 4, 2024
|
|
||
| server := &metalv1alpha1.Server{} | ||
| if err := r.Client.Get(ctx, client.ObjectKey{Name: claim.Spec.ServerRef.Name}, server); err != nil { | ||
| if err := r.Client.Get(ctx, client.ObjectKey{Name: claim.Spec.ServerRef.Name}, server); err != nil && !apierrors.IsNotFound(err) { |
Member
There was a problem hiding this comment.
I would add here an if statement + logging. Something along the line: log.Info("Server gone")
Member
Author
There was a problem hiding this comment.
Sounds good, made changes !!
afritzler
changed the title
ServerClaim when Server does not exist
hardikdr
force-pushed
the
fix/allow-deleting-serverclaim
branch
2 times, most recently
from
2528add to
59d08d6
Compare
hardikdr
force-pushed
the
fix/allow-deleting-serverclaim
branch
from
59d08d6 to
c248b55
Compare
afritzler
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow deletion of the ServerClaim incase Server doesnt exist.
Fixes #