Skip to content

[NX-OS] Separate feature activation from configuration#155

Merged
felix-kaestner merged 1 commit intomainfrom
nxos-feature-activation
Jan 20, 2026
Merged

[NX-OS] Separate feature activation from configuration#155
felix-kaestner merged 1 commit intomainfrom
nxos-feature-activation

Conversation

@felix-kaestner
Copy link
Copy Markdown
Contributor

@felix-kaestner felix-kaestner commented Jan 19, 2026

Problem

NX-OS versions prior to 10.6(3) have an issue where YANG configuration is not persisted when feature activation is mixed with dependent configuration in the same gNMI request. The configuration appears in YANG queries but not in the running config.

Solution

This PR implements a workaround by separating feature activation from dependent configuration into separate gNMI transactions for affected versions (≤10.6(2)).

Relates to #148

@felix-kaestner felix-kaestner requested a review from a team as a code owner January 19, 2026 18:47
@felix-kaestner felix-kaestner force-pushed the nxos-feature-activation branch from 9c86dea to 47ac8d7 Compare January 19, 2026 19:19
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jan 20, 2026
@hardikdr hardikdr added this to Roadmap Jan 20, 2026
@felix-kaestner felix-kaestner force-pushed the nxos-feature-activation branch 2 times, most recently from 1459984 to bfe6337 Compare January 20, 2026 09:55
Copy link
Copy Markdown
Contributor

@nikatza nikatza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

NX-OS versions prior to 10.6(3) have an issue where YANG configuration
is not persisted when feature activation is mixed with dependent
configuration in the same gNMI request. The configuration shows up in
YANG queries but not in the running config.

This implements a workaround by separating feature activation from
dependent configuration into separate gNMI transactions for affected
versions.

Relates to #148
@felix-kaestner felix-kaestner force-pushed the nxos-feature-activation branch from bfe6337 to 16a3a8a Compare January 20, 2026 09:57
@github-actions
Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2 90.58% (-0.48%) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr 48.10% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 11.25% (-0.11%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2/client.go 88.54% (-0.57%) 157 (+1) 139 18 (+1) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.07% (-0.00%) 1438 (+21) 1 1437 (+21) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/version.go 0.00% (ø) 7 0 7

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/provider_test.go

@felix-kaestner felix-kaestner merged commit 0844276 into main Jan 20, 2026
10 of 11 checks passed
@felix-kaestner felix-kaestner deleted the nxos-feature-activation branch January 20, 2026 13:37
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Jan 20, 2026
felix-kaestner added a commit that referenced this pull request Jan 26, 2026
NX-OS versions prior to 10.6(3) have an issue where YANG configuration
is not persisted when feature activation is mixed with dependent
configuration in the same gNMI request. The configuration shows up in
YANG queries but not in the running config.

This implements a workaround by separating feature activation from
dependent configuration into separate gNMI transactions for affected
versions.

Relates to #148
swagner-de pushed a commit that referenced this pull request Jan 27, 2026
NX-OS versions prior to 10.6(3) have an issue where YANG configuration
is not persisted when feature activation is mixed with dependent
configuration in the same gNMI request. The configuration shows up in
YANG queries but not in the running config.

This implements a workaround by separating feature activation from
dependent configuration into separate gNMI transactions for affected
versions.

Relates to #148
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants