Add peer interface annotation for physical interfaces#191
Merged
felix-kaestner merged 1 commit intomainfrom Mar 4, 2026
Merged
Add peer interface annotation for physical interfaces#191felix-kaestner merged 1 commit intomainfrom
felix-kaestner merged 1 commit intomainfrom
Conversation
328466a to
6f0d313
Compare
nikatza
reviewed
Feb 19, 2026
|
do we want to use an annotation in this case ? this makes it harder for cli tools to display / filter for it correctly I think |
6f0d313 to
f9dff4d
Compare
Contributor
Author
@SchwarzM Changed to a label with a same-namespace constraint - the value is now just the interface name (no namespace prefix). This enables filtering while keeping the value label-compatible. |
f9dff4d to
69e45b9
Compare
nikatza
approved these changes
Mar 4, 2026
Contributor
nikatza
left a comment
There was a problem hiding this comment.
Nice, thanks for the update!
69e45b9 to
ace4a09
Compare
This patch introduces the `PhysicalInterfaceNeighborLabel` label which references the peer Interface resource on the other end of a physical link. The label can be used by users to declare expected cabling, or by controllers to reflect actual cabling discovered via neighbor discovery protocols (e.g., LLDP). The label value must be the name of another Interface resource in the same namespace. It is only valid for interfaces of type Physical. Additionally, a `PhysicalInterfaceNeighborRawAnnotation` annotation is introduced for interfaces connected to unmanaged devices (devices without an Interface resource). The annotation value format is "chassisID::portID" where chassisID is the LLDP chassis identifier and portID is the LLDP port identifier. Both the label and annotation are mutually exclusive - an interface cannot have both set at the same time.
ace4a09 to
4923568
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the
PhysicalInterfaceNeighborLabellabel whichreferences the peer Interface resource on the other end of a physical
link. The label can be used by users to declare expected cabling, or
by controllers to reflect actual cabling discovered via neighbor
discovery protocols (e.g., LLDP).
The label value must be the name of another Interface resource in the
same namespace. It is only valid for interfaces of type Physical.
Additionally, a
PhysicalInterfaceNeighborRawAnnotationannotation isintroduced for interfaces connected to unmanaged devices (devices
without an Interface resource). The annotation value format is
"chassisID::portID" where chassisID is the LLDP chassis identifier
and portID is the LLDP port identifier.
Both the label and annotation are mutually exclusive - an interface
cannot have both set at the same time.