[NXOS] Fix bfd spec mapping to feature configuration#259
Merged
felix-kaestner merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
felix-kaestner
force-pushed
the
fix-bfd
branch
2 times, most recently
from
0d228ed to
13b131a
Compare
Commit 838ddc7 introduced a regression, where we would configure the BFD of the interface unconditionally, even in the case where the feature is not even activated, leading to `BFD feature is not enabled Commit Failed` errors. This issue is fixed with this change, which correctly differentiates the BFD spec cases between enabled, disabled and nil/unspecified. It also covers some additional fixes related to BFD. Fix nil pointer dereferences in EnsureISIS when accessing BFD.Enabled on interfaces without BFD configuration. Fix inverted BFD control logic in EnsureOSPF where .spec.bfd.enabled=true was incorrectly mapped to OspfBfdCtrlDisabled and vice versa.
felix-kaestner
changed the title
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
hardikdr
added
the
area/switch-automation
nikatza
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 838ddc7 introduced a regression, where we would configure the BFD
of the interface unconditionally, even in the case where the feature is
not even activated, leading to
BFD feature is not enabled Commit Failederrors.
This issue is fixed with this change, which correctly differentiates the
BFD spec cases according to the following mappings.
.spec.bfd.enabled = true
.spec.bfd.enabled = false
.spec.bfd = nil
It also covers some additional fixes related to BFD.
Fix nil pointer dereferences in EnsureISIS when accessing BFD.Enabled
on interfaces without BFD configuration.
Fix inverted BFD control logic in EnsureOSPF where .spec.bfd.enabled=true
was incorrectly mapped to OspfBfdCtrlDisabled and vice versa.