Skip to content

Upgrade controller-runtime to v0.24.1 and k8s.io/* to v1.36#339

Merged
felix-kaestner merged 2 commits into
mainfrom
chore/dep-controller-runtime-up
Jun 16, 2026
Merged

Upgrade controller-runtime to v0.24.1 and k8s.io/* to v1.36#339
felix-kaestner merged 2 commits into
mainfrom
chore/dep-controller-runtime-up

Conversation

@felix-kaestner

@felix-kaestner felix-kaestner commented May 5, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the size/L label May 5, 2026
@felix-kaestner felix-kaestner force-pushed the chore/dep-controller-runtime-up branch from ce05cdd to 218f95c Compare May 5, 2026 19:49
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label May 6, 2026
@hardikdr hardikdr added this to Roadmap May 6, 2026
@felix-kaestner felix-kaestner force-pushed the chore/dep-controller-runtime-up branch 5 times, most recently from 0c617ab to 6543924 Compare May 11, 2026 20:04
@felix-kaestner felix-kaestner force-pushed the chore/dep-controller-runtime-up branch from 6543924 to 1913769 Compare May 20, 2026 12:21
@felix-kaestner felix-kaestner force-pushed the chore/dep-controller-runtime-up branch from 1913769 to bb19d4f Compare June 16, 2026 11:10
@felix-kaestner felix-kaestner marked this pull request as ready for review June 16, 2026 11:11
@felix-kaestner felix-kaestner requested a review from a team as a code owner June 16, 2026 11:11
@felix-kaestner felix-kaestner changed the title Upgrade controller-runtime to v0.24.0 and k8s.io/* to v1.36 Upgrade controller-runtime to v0.24.1 and k8s.io/* to v1.36 Jun 16, 2026
@felix-kaestner felix-kaestner force-pushed the chore/dep-controller-runtime-up branch from bb19d4f to e725131 Compare June 16, 2026 11:17
@felix-kaestner
Upgrade controller-runtime to v0.24.1 and k8s.io/* to v1.36
9a80299 
See: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.24.0
See: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.24.1

Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
@felix-kaestner
Replace deprecated scheme.Builder with runtime.NewSchemeBuilder
90629cc 
controller-runtime v0.24.0 deprecated the scheme.Builder helper.
Replace it with k8s.io/apimachinery/pkg/runtime.NewSchemeBuilder
and register types via s.AddKnownTypes following upstream patterns.

Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
@felix-kaestner felix-kaestner force-pushed the chore/dep-controller-runtime-up branch from e725131 to 90629cc Compare June 16, 2026 16:05
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/api/cisco/xe/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/api/cisco/xr/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/bgpconfig_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/bordergateway_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/interfaceconfig_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/lldpconfig_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/managementaccessconfig_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/nveconfig_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/system_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/vpcdomain_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/xe/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/xr/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/acl_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/banner_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/bgp_peer_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/bgp_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/certificate_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/device_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/dhcprelay_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/dns_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/evpninstance_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/interface_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/isis_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/lldp_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/managementaccess_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/ntp_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/nve_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/ospf_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/pim_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/prefixset_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/routingpolicy_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/snmp_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/syslog_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/user_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/vlan_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/vrf_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@felix-kaestner felix-kaestner merged commit be44e79 into main Jun 16, 2026
18 checks passed
@felix-kaestner felix-kaestner deleted the chore/dep-controller-runtime-up branch June 16, 2026 16:54
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swagner-de swagner-de swagner-de approved these changes

Assignees

No one assigned

Labels

area/switch-automation Automation processes for network switch management and operations. size/L

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felix-kaestner @swagner-de @hardikdr