Skip to content

Add timeout to Provisioned phase post-provisioning checks#387

Merged
felix-kaestner merged 1 commit into
mainfrom
fix/provisioned-phase-timeout
May 29, 2026
Merged

Add timeout to Provisioned phase post-provisioning checks#387
felix-kaestner merged 1 commit into
mainfrom
fix/provisioned-phase-timeout

Conversation

@swagner-de
Copy link
Copy Markdown
Contributor

Devices stuck in Provisioned with repeatedly failing VerifyProvisioned
would loop indefinitely. Transition to Failed after one hour from
StartTime, consistent with the Provisioning phase timeout.

Signed-off-by: Sebastian Wagner sebastian.wagner02@sap.com

Devices stuck in Provisioned with repeatedly failing VerifyProvisioned
would loop indefinitely. Transition to Failed after one hour from
StartTime, consistent with the Provisioning phase timeout.

Signed-off-by: Sebastian Wagner <sebastian.wagner02@sap.com>
@swagner-de swagner-de requested a review from a team as a code owner May 29, 2026 14:51
Copy link
Copy Markdown

@SchwarzM SchwarzM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnagna hardcoded stuff .. gnagna lgtm

@github-actions
Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/controller/core 62.59% (+0.12%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/controller/core/device_controller.go 66.67% (+0.13%) 252 (+4) 168 (+3) 84 (+1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@felix-kaestner felix-kaestner merged commit 5001d35 into main May 29, 2026
20 checks passed
@felix-kaestner felix-kaestner deleted the fix/provisioned-phase-timeout branch May 29, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants