Skip to content

Add Firebase setup guide and SVG icon #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iostpa merged 2 commits into from
Sep 30, 2025
Merged

Add Firebase setup guide and SVG icon #102

iostpa merged 2 commits into from
Sep 30, 2025

Conversation

@MarkCay
Copy link
Contributor

@MarkCay MarkCay commented Sep 28, 2025

Hi! I just wanna add a new guide for develoeprs who used Firebase Hosting to deploy their site.

@MarkCay MarkCay requested a review from a team as a code owner September 28, 2025 16:51
iostpa
iostpa requested changes Sep 28, 2025
View reviewed changes
@MarkCay
Copy link
Contributor Author

MarkCay commented Sep 29, 2025

Hi @iostpa! Sorry about that, I have already updated the Firebase Hosting link and reviewed all of my changes.

@MarkCay MarkCay requested a review from iostpa September 30, 2025 02:56
iostpa
iostpa approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@iostpa iostpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge since I have seen web.app domains before. (I think)

@iostpa iostpa merged commit 713201e into is-a-dev:main Sep 30, 2025
@MarkCay
Copy link
Contributor Author

MarkCay commented Sep 30, 2025

I'll merge since I have seen web.app domains before. (I think)

Yes, when you deploy a site via Firebase Hosting, it will be accessible both on .web.app and '.firebaseapp.com`.This is the same method I used to deploy my own markcay.is-a.dev link (is-a-dev/register#26905). Thanks @iostpa!

@iostpa
Copy link
Member

iostpa commented Sep 30, 2025

I'll merge since I have seen web.app domains before. (I think)

Yes, when you deploy a site via Firebase Hosting, it will be accessible both on .web.app and '.firebaseapp.com`.This is the same method I used to deploy my own markcay.is-a.dev link (is-a-dev/register#26905). Thanks @iostpa!

If it was just one pull request I wouldn't have merged it, but I remember other pull requests that were like yours so that's why I decided to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iostpa iostpa iostpa approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarkCay @iostpa