Skip to content

Remove postcodes from Admin user search#784

Merged
axlewin merged 1 commit into
mainfrom
improvement/remove-postcodes
May 1, 2026
Merged

Remove postcodes from Admin user search#784
axlewin merged 1 commit into
mainfrom
improvement/remove-postcodes

Conversation

@jsharkey13
Copy link
Copy Markdown
Member

If postcode filtering was used with no other search terms, every single user was loaded from the database and we then attempted to filter them. This is not sustainable, and indeed did not work reliably. We can better filter users offline if we need location-based subsets.

This also allows us to remove all the apparatus for finding the lat-lon of postcodes we did not already have, too.

If postcode filtering was used with no other search terms, every single
user was loaded from the database and we then attempted to filter them.
This is not sustainable, and indeed did not work.
We can better filter users offline if we need location-based subsets.

This also allows us to remove all the apparatus for finding the lat-lon
of postcodes we did not already have, too.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.12%. Comparing base (31ef070) to head (14dc092).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/uk/ac/cam/cl/dtg/segue/api/AdminFacade.java 0.00% 1 Missing ⚠️
...va/uk/ac/cam/cl/dtg/segue/dao/LocationManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   40.28%   40.12%   -0.16%     
==========================================
  Files         546      543       -3     
  Lines       23794    23571     -223     
  Branches     2904     2867      -37     
==========================================
- Hits         9585     9458     -127     
+ Misses      13309    13229      -80     
+ Partials      900      884      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@axlewin axlewin merged commit 6a7391c into main May 1, 2026
5 checks passed
@axlewin axlewin deleted the improvement/remove-postcodes branch May 1, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants