Fix palette import path for OJS runtime#115
Merged
rdhyee merged 1 commit intoisamplesorg:mainfrom Apr 16, 2026
Merged
Conversation
OJS resolves relative imports against its own runtime path (/site_libs/quarto-ojs/), not the page URL — so ../assets/js/... became /site_libs/assets/js/... (404). Use an absolute URL built from document.baseURI so it resolves against the page instead. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #114.
OJS resolves relative imports against its own runtime path (
/site_libs/quarto-ojs/), not the page URL, so../assets/js/source-palette.jswas being fetched fromhttps://isamples.org/site_libs/assets/js/source-palette.js(404) and breaking every OJS cell downstream.Fix: compute an absolute URL from
document.baseURI:Verified with Playwright against a local render: module loads,
SOURCE_COLORSexposed correctly.Test plan
quarto render tutorials/progressive_globe.qmdsucceeds/assets/js/source-palette.jsreturns the expected palette🤖 Generated with Claude Code