Move Explorer perf panel to plain <script> (OJS cell wasn't firing)#125
Merged
rdhyee merged 2 commits intoisamplesorg:mainfrom Apr 17, 2026
Merged
Conversation
Without output: false and with an html return value, the cell is treated as displayed and therefore evaluated. The original version was being skipped by OJS's dead-code elimination because no other cell referenced perfPanel and output was suppressed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
OJS reactive graph was inconsistently evaluating the perfPanel cell (appeared in docs/isamples_explorer.html as ojs-cell-34 but never fired on page load, even 50s after all explorer_* marks landed and sampleData was observed). Progressive_globe's structurally identical cell works fine — suspect page-specific timing or dependency ordering. Replace with a plain <script> block in include-in-header that runs independent of OJS. Polls for performance marks every 500ms and re-renders the panel as each new mark arrives, stops polling once explorer-samples-end and explorer-count-end are both present. Gated on ?perf=1 (no-op otherwise). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124: the OJS perfPanel cell wasn't evaluating on page load. Replaced with a plain
<script>in include-in-header that polls for marks. Still gated on?perf=1.