Skip to content

[codex] Phase 3: add globe URL params and multi-term search#159

Merged
rdhyee merged 2 commits intoisamplesorg:mainfrom
rdhyee:codex/issue-156-phase-3-url-search
May 1, 2026
Merged

[codex] Phase 3: add globe URL params and multi-term search#159
rdhyee merged 2 commits intoisamplesorg:mainfrom
rdhyee:codex/issue-156-phase-3-url-search

Conversation

@rdhyee
Copy link
Copy Markdown
Contributor

@rdhyee rdhyee commented May 1, 2026

Summary

Implements issue #156 Phase 3 on top of the merged Phase 1 work.

  • adds query param read/write for q, sources, material, context, object_type, maxSamples, view, and perf
  • hydrates search and filters while preserving existing hash camera/sample state
  • folds in multi-term AND search with relevance ordering using the globe page query style

Verification

  • quarto render tutorials/progressive_globe.qmd
  • git diff --check

Draft because phases 2, 3, and 4 are parallel PRs and may need final integration ordering.

@rdhyee
Copy link
Copy Markdown
Contributor Author

rdhyee commented May 1, 2026

Review finding: ?q= is restored into the search box, but the search is not executed on page load. A shared URL like ...?q=pottery%20Cyprus renders the input value while leaving the results panel unchanged until the user manually clicks Search or presses Enter. For the URL params + multi-term search behavior, the visible search state should be restored automatically.

@rdhyee
Copy link
Copy Markdown
Contributor Author

rdhyee commented May 1, 2026

Addressed in c06dd02: restored ?q= searches now run automatically after the search handlers are bound, so shared query URLs populate the visible results without requiring a manual Search click.

@rdhyee rdhyee force-pushed the codex/issue-156-phase-3-url-search branch from c06dd02 to 62a286e Compare May 1, 2026 17:42
@rdhyee rdhyee marked this pull request as ready for review May 1, 2026 17:42
@rdhyee rdhyee merged commit c0b222c into isamplesorg:main May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant