Fix: Correct secrets access in reusable workflow #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reusable workflows (workflow_call), secrets need to be checked with != '' syntax, not just using && boolean logic. Also removed the unnecessary if condition on the Claude step since ANTHROPIC_API_KEY is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The workflow was failing with errors:
Unrecognized named-value: 'secrets'on line 47 and 55Root Cause
In reusable workflows with
workflow_call, secrets cannot be checked with simple boolean logic likesecrets.APP_ID && secrets.APP_PRIVATE_KEY. They must be compared with empty string.Solution
secrets.APP_ID && secrets.APP_PRIVATE_KEYtosecrets.APP_ID != '' && secrets.APP_PRIVATE_KEY != ''ifcondition on Claude step since ANTHROPIC_API_KEY is required anywayTesting
This should fix the workflow validation errors.