Guard NBITS=16 against GDAL Float16 / rasterio incompatibility#690
Merged
mirzaees merged 2 commits intoisce-framework:mainfrom Mar 16, 2026
Merged
Conversation
GDAL 3.11+ interprets NBITS=16 on float32 GeoTIFFs as native Float16 (datatype code 15). Rasterio builds that lack a mapping for code 15 then raise `KeyError: 15` on open. Add `_can_use_nbits16()` that checks for this mismatch and gates all NBITS=16 usage behind it. On old GDAL the behavior is unchanged; on new GDAL the option is skipped until rasterio adds Float16 support. Fixes isce-framework#687 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Just confirming that my environment upgraded to rasterio 1.4.4, I got the same ...
File "/Users/staniewi/repos/dolphin/src/dolphin/workflows/single.py", line 424, in run_wrapped_phase_single
io.repack_rasters(phase_linked_crlb_files, use_16_bits=True)
...
File "/Users/staniewi/miniforge3/envs/mapping-312/lib/python3.12/site-packages/rasterio/__init__.py", line 366, in open
dataset = writer(
^^^^^^^
File "rasterio/_io.pyx", line 1636, in rasterio._io.DatasetWriterBase.__init__
File "rasterio/_base.pyx", line 967, in rasterio._base.DatasetBase.meta.__get__
File "rasterio/_base.pyx", line 506, in rasterio._base.DatasetBase.dtypes.__get__
File "rasterio/_base.pyx", line 176, in rasterio._base._band_dtype
KeyError: 15but then tried this fix and it ran through |
The original commit only guarded the write path
mirzaees
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDAL 3.11+ interprets NBITS=16 on float32 GeoTIFFs as native Float16 (datatype code 15). Rasterio builds that lack a mapping for code 15 then raise
KeyError: 15on open.Add
_can_use_nbits16()that checks for this mismatch and gates all NBITS=16 usage behind it. On old GDAL the behavior is unchanged; on new GDAL the option is skipped until rasterio adds Float16 support.Fixes issue raise in #687, specifically: #687 (comment)
Change Summary
Related issue number
Checklist