Fix GCOV polarimetric symmetrization metadata #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyler-g-hudson
approved these changes
Oct 29, 2025
Contributor
Tyler-g-hudson
left a comment
Tyler-g-hudson
left a comment
There was a problem hiding this comment.
LGTM, couple of nitpicks
Co-authored-by: Tyler G. Hudson <tyler.g.hudson@gmail.com>
Tyler-g-hudson
added a commit
that referenced
this pull request
Oct 31, 2025
* disable polarimetric symmetrization by default * revert changes to `symmetrize_cross_pol_channels` * Update GCOV and GSLC specification XMLs * Revert changes to the GCOV and GSLC specification XMLs * fix polarimetric symmetrization metadata * Update python/packages/nisar/products/writers/GcovWriter.py Co-authored-by: Tyler G. Hudson <tyler.g.hudson@gmail.com> --------- Co-authored-by: Tyler G. Hudson <tyler.g.hudson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the GCOV polarimetric symmetrization metadata. It corrects the logic for storing the H5 datasets
polarimetricSymmetrizationAppliedandalgorithms/polarimetricSymmetrization.Previously, the flag polarimetricSymmetrizationApplied depended solely on the runconfig field
symmetrize_cross_pol_channels, without verifying whether both cross-polarimetric channels were present in the input file. Additionally, the check for the existence of these polarization channels was incorrect when setting thealgorithms/polarimetricSymmetrizationdataset.