Checking in IO protocols and readers#3
Conversation
piyushrpt
commented
Mar 26, 2024
- IO protocols
- Basic raster based reader to read test data
gmgunter
left a comment
There was a problem hiding this comment.
Good stuff, thanks. Few questions and suggestions below.
Apologies in advance if some comments are outdated -- looks like some updates came in as I was finishing up my review.
Sorry, can you revert this commit and put it in a separate PR? If you're comfortable with I concede that that's a lot more burdensome on you when the PRs have dependencies on each other, but it makes my life as a reviewer a lot easier. I can get through a bunch of smaller PRs much more efficiently than one big PR. No worries if reverting the commit is a problem this time, but going forward let's try to figure out a workflow that involves chaining multiple smaller PRs, since that's the only way that I'll realistically be able to continue reviewing them. |
|
Ignore the Delaunay files for now. Moving forward, I will daisy chain the PRs. The next PR will be Delaunay related and we can discuss that in more detail then. |
gmgunter
left a comment
There was a problem hiding this comment.
Big fan of the updated docstrings. It's a lot more clear what's going on now, thanks.
Just a heads up -- if I add more than like 10 review comments at once, GitHub collapses some of the comments and you need to click on [Load more...] to reveal them. You might not have seen some of my earlier comments because of this.
Moving forward, I will daisy chain the PRs.
Thanks! I really appreciate it.
gmgunter
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing all of my questions and comments
