ci: include release version in gh release name#2658
Open
holysoles wants to merge 1 commit intoish-app:masterfrom
Open
ci: include release version in gh release name#2658holysoles wants to merge 1 commit intoish-app:masterfrom
holysoles wants to merge 1 commit intoish-app:masterfrom
Conversation
Author
|
I tried for awhile to test this in my fork, but I had a hell of a time trying to get this to build there without having the code-signing setup configured. However usage of get_version_number seems straightforward enough matches usage of other similar fastlane actions being used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the ish.app AltStore source is incompatible with AltStore 2.0 and SideStore (#2563). The previous attempt of trying to solve this on the ish.app project (ish-app/ish.app#46) was hardcoding the version number, which was an area of feedback that couldn't be addressed, since a given GitHub release provides no indication of the app version that the build is for.
Solution
This PR names each nightly release as a semver formatted version number of
<app version>-build<build number>. No changes are made to the testflight upload or the actual artifact versions themselves.With this change, we can then parse this information in the template to provide both the app version and build number to the appropriate AltStore Source fields. I've opened a PR over on the ish.app project to do that (ish-app/ish.app#48).
Closes #2563