Skip to content

privately link fmt, but propagate its header#4779

Merged
yxlao merged 2 commits intomasterfrom
yixing/private-fmt
Feb 19, 2022
Merged

privately link fmt, but propagate its header#4779
yxlao merged 2 commits intomasterfrom
yixing/private-fmt

Conversation

@yxlao
Copy link
Copy Markdown
Collaborator

@yxlao yxlao commented Feb 19, 2022

This issue was introduced in #4692.

After installation

~ tree open3d_install/include/open3d/3rdparty/fmt  
open3d_install/include/open3d/3rdparty/fmt
├── chrono.h
├── color.h
├── compile.h
├── core.h
├── format.h
├── format-inl.h
├── locale.h
├── ostream.h
├── posix.h
├── printf.h
├── ranges.h
└── safe-duration-cast.h

0 directories, 12 files
➜  ~ tree open3d_install/lib                        
open3d_install/lib
├── cmake
│   └── Open3D
│       ├── Open3DConfig.cmake
│       ├── Open3DConfigVersion.cmake
│       ├── Open3DTargets.cmake
│       └── Open3DTargets-relwithdebinfo.cmake
└── libOpen3D.so

2 directories, 5 files

This change is Reviewable

@update-docs
Copy link
Copy Markdown

update-docs bot commented Feb 19, 2022

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@yxlao yxlao requested a review from ssheorey February 19, 2022 03:42
@yxlao yxlao merged commit 9da1f9e into master Feb 19, 2022
@yxlao yxlao deleted the yixing/private-fmt branch February 19, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants