issue 57#66
Merged
Merged
Conversation
Collaborator
|
Yes please do that.
…On Tue, 26 Nov 2024 at 12:02, Iso ***@***.***> wrote:
-The readthedocs file was already created but it needs to be .yaml so i
renamed it.
-now i will make the repo public and host the documentations and check for
errors.
------------------------------
You can view, comment on, or merge this pull request online at:
#66
Commit Summary
- d7e905c
<d7e905c>
changed the file name to .yaml
File Changes
(1 file <https://github.com/Issamricin/dmc-view/pull/66/files>)
- *R* .readthedocs.yaml
<https://github.com/Issamricin/dmc-view/pull/66/files#diff-03efc769b870804394632e45d7885272b44c16939517fb31c9d7c614d2ffae57>
(0)
Patch Links:
- https://github.com/Issamricin/dmc-view/pull/66.patch
- https://github.com/Issamricin/dmc-view/pull/66.diff
—
Reply to this email directly, view it on GitHub
<#66>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPJ5IQ3XWNJJZGM2IM4GL2CRIKZAVCNFSM6AAAAABSQEUW2WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TIMRTGI4TQOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Owner
Author
|
i am going to merge this pr before? |
Owner
Author
|
also don't we need to merge develop into master before ? since readthedocs will read from master. or should we specify the default branch in readthedocs.yaml as develop. (default_branch: develop) ? |
Collaborator
|
Merge. If you don't need the branch any more, delete it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-The readthedocs file was already created but it needs to be .yaml so i renamed it.
-now i will make the repo public and host the documentations and check for errors.