feat!: support external KMS to secure GitHub App credentials #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for external KMS to secure private keys:
- AWS KMS,
- GCP KMS,
- HashiCorp Vault.
When using external KMS, the private key is stored in the KMS and all
JWT signing operations are performed using the KMS API.
* Refactor configuration to better align with support for external KMS.
Configuration secret, file name and keys are updated to better reflect
the new functionality.
* Support full configuration via environment (best with KMS providers).
* Re-enable HTTP2 by default.
* Update Operator-SDK and dependencies to latest versions.
isometry
force-pushed
the
feature/kms-signers
branch
from
8c69a1d to
52844c3
Compare
isometry
added a commit
that referenced
this pull request
Oct 14, 2024
* Add support for external KMS to secure private keys:
- AWS KMS,
- GCP KMS,
- HashiCorp Vault.
When using external KMS, the private key is stored in the KMS and all
JWT signing operations are performed using the KMS API.
* Refactor configuration to better align with support for external KMS.
Configuration secret, file name and keys are updated to better reflect
the new functionality.
* Support full configuration via environment (best with KMS providers).
* Re-enable HTTP2 by default.
* Update Operator-SDK and dependencies to latest versions.
isometry
added a commit
that referenced
this pull request
Oct 14, 2024
* Add support for external KMS to secure private keys:
- AWS KMS,
- GCP KMS,
- HashiCorp Vault.
When using external KMS, the private key is stored in the KMS and all
JWT signing operations are performed using the KMS API.
* Refactor configuration to better align with support for external KMS.
Configuration secret, file name and keys are updated to better reflect
the new functionality.
* Support full configuration via environment (best with KMS providers).
* Re-enable HTTP2 by default.
* Update Operator-SDK and dependencies to latest versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for external KMS to secure private keys:
When using external KMS, the private key is stored in the KMS and all
JWT signing operations are performed using the KMS API.
Refactor configuration to better align with support for external KMS.
Configuration secret, file name and keys are updated to better reflect
the new functionality.
Support full configuration via environment (best with KMS providers).
Re-enable HTTP2 by default.
Update Operator-SDK and dependencies to latest versions.