chore: Use class to declare NYC#1069
Merged
coreyfarrell merged 1 commit intoistanbuljs:masterfrom Apr 17, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intentionally avoids all auxiliary changes, this is a pure conversion from prototype based object to class based object. If you download and view with
git diff HEAD~1 --ignore-all-spacethe patch is 90% smaller (only adds/deletes 45 lines).One change of code
nyc.generateUniqueID()no longer exists. This was only used by the constructor which now just callsuuid()directly.coverageFinderis moved from the middle of the file to the top but is otherwise unchanged. I did it this way as I didn't want to mix relevant changes with a formatting change effecting 90% of index.js.