Skip to content

Support Envoy Native Subset Load Balancing[WIP] #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support Envoy Native Subset Load Balancing[WIP] #2082

wants to merge 2 commits into from

Conversation

@l8huang
Copy link

@l8huang l8huang commented Aug 19, 2021

This PR include changes to VirtualService and DestinationRule for supporting Envoy native subset load balancing.

design doc link will be added after it's moved into istio community drive.

l8huang added 2 commits July 13, 2021 09:33
@l8huang
Modify DestinationRule to support subset load balancer
2c5434f
@l8huang
Add Header-to-Metada support to VirtualService
0fa29a8 
Add HTTPHeaderToMetadata and HTTPLoadBalance to virtual_service.proto,
HTTPLoadBalance will use HTTPHeaderToMetadata to add metadata to metadata
namespace `envoy.lb`; these metadata could be used by subset load balancing
defined by DestinationRule.
@istio-policy-bot
Copy link

😊 Welcome @l8huang! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 19, 2021
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 19, 2021
@istio-testing
Copy link
Collaborator

@l8huang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2021
@istio-testing
Copy link
Collaborator

@l8huang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
build_api 0fa29a8 link /test build_api
gencheck_api 0fa29a8 link /test gencheck_api
release-notes_api 0fa29a8 link /test release-notes_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@istio-testing
Copy link
Collaborator

@l8huang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
build_api 0fa29a8 link /test build_api
gencheck_api 0fa29a8 link /test gencheck_api
release-notes_api 0fa29a8 link /test release-notes_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@l8huang l8huang mentioned this pull request Aug 19, 2021
Closed
@l8huang l8huang changed the title Support Envoy Native Subset Load Balancing Support Envoy Native Subset Load Balancing[WIP] Aug 19, 2021
@hzxuzhonghu
Copy link
Member

Can you write a proposal first?

@l8huang
Copy link
Author

l8huang commented Aug 23, 2021

Can you write a proposal first?

see RFC: Support Envoy Native Subset Load Balancing

@howardjohn howardjohn removed the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 15, 2024
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-08-23. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-avery brian-avery Awaiting requested review from brian-avery

@howardjohn howardjohn Awaiting requested review from howardjohn

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@nrjpoddar nrjpoddar Awaiting requested review from nrjpoddar

@smawson smawson Awaiting requested review from smawson

Assignees

No one assigned

Labels

lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@l8huang @istio-policy-bot @istio-testing @hzxuzhonghu @howardjohn