Skip to content

Conversation

@iwanaga
Copy link
Contributor

@iwanaga iwanaga commented Oct 8, 2025

Corrected an error in the config example.

Confirmed that the validation now passes as shown below.
Invalid when we use from_cookies as a field name:

k apply --dry-run=server -f test-jwt.yaml
Error from server (BadRequest): error when creating "test-jwt.yaml": RequestAuthentication in version "v1" cannot be handled as a RequestAuthentication: strict decoding error: unknown field "spec.jwtRules[0].from_cookies"

Valid when we use fromCookies:

k apply --dry-run=server -f test-jwt.yaml
requestauthentication.security.istio.io/jwt-on-ingress created (server dry run)

@iwanaga iwanaga requested a review from a team as a code owner October 8, 2025 10:13
@istio-policy-bot
Copy link

😊 Welcome @iwanaga! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Oct 8, 2025
@istio-testing
Copy link
Collaborator

Hi @iwanaga. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ilrudie
Copy link
Contributor

ilrudie commented Oct 8, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 8, 2025
@ilrudie ilrudie added the release-notes-none Indicates a PR that does not require release notes. label Oct 8, 2025
@ilrudie
Copy link
Contributor

ilrudie commented Oct 8, 2025

/test release-notes

Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@istio-testing istio-testing merged commit 6df984a into istio:master Oct 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants