Skip to content

Conversation

@grnmeira
Copy link

This reverts commit 20d26b4.

@grnmeira grnmeira requested a review from a team as a code owner October 27, 2025 09:45
@grnmeira grnmeira added the do-not-merge Block automatic merging of a PR. label Oct 27, 2025
@istio-policy-bot
Copy link

😊 Welcome @grnmeira! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2025
@grnmeira grnmeira added the release-notes-none Indicates a PR that does not require release notes. label Oct 27, 2025
@grnmeira grnmeira changed the title Revert "Support EnvoyFilter in Waypoint (#3577)" [release-1.28] Revert "Support EnvoyFilter in Waypoint (#3577)" Oct 27, 2025
@grnmeira
Copy link
Author

/test release-notes

@keithmattix
Copy link
Contributor

#3589 should fix this

@zirain
Copy link
Member

zirain commented Oct 27, 2025

#3589 should fix this

@keithmattix this's required if we cannot merge istio/istio#57971 into release-1.28.
that's why @grnmeira put an DNM.

@keithmattix
Copy link
Contributor

Ah my bad; makes sense

Copy link
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case this is needed

@fjglira
Copy link
Contributor

fjglira commented Oct 27, 2025

The PR is needed, TOC did not approve the merge of the feature into the release 1.28 branch: istio/istio#57971 (comment)

@fjglira fjglira removed the do-not-merge Block automatic merging of a PR. label Oct 27, 2025
@istio-testing istio-testing merged commit a5aa715 into istio:release-1.28 Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants