Add documentation for IST0143 #9522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
google-cla
bot
added
the
cla: yes
ericvn
reviewed
Apr 14, 2021
| When this occurs, the port will not be accessible to other pods. | ||
|
|
||
| This check is primarily added to detect workloads on older Istio versions that may break when upgrading to Istio 1.10 or later. | ||
| This behavior matches what would occur in a standard Kubernetes cluster without Istio, but older versions of Istio exposed these ports |
There was a problem hiding this comment.
missing period at end of sentence.
|
|
||
| If you did not intend to expose the application to other pods, you can remove the port from the `Service`. | ||
|
|
||
| if you do want to expose the application to other pods, there are two options |
There was a problem hiding this comment.
Missed the capitalization of first word in the sentence.
|
|
||
| ## An example | ||
|
|
||
| Consider a `Service` like below: |
| app: netcat | ||
| {{< /text >}} | ||
|
|
||
| Selecting a `Pod` running the command `nc localhost 8080`. |
There was a problem hiding this comment.
I'm confused by this sentence. Maybe combine with the next sentence and better describe what works in one pod (with the service) and another without.
ericvn
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highly related #9150