Skip to content

Conversation

@massaox
Copy link

@massaox massaox commented May 25, 2021

[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

massaox added 2 commits May 25, 2021 10:37
Adding Jetstack logo
Adding Jetstack logo
@massaox massaox requested review from a team as code owners May 25, 2021 09:39
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines,
    and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be
    built as a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the Status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
    to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    status section of the page. Click on the Details link to get a list of the problems with your PR.
    Fix those problems and push an update to your PR. This will automatically rerun the tests and
    hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla
Copy link

google-cla bot commented May 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2021
@google-cla google-cla bot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 25, 2021
@istio-testing
Copy link
Contributor

Hi @massaox. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ericvn
ericvn previously approved these changes May 25, 2021
logo: "/logos/zendesk.svg"
url: "https://www.zendesk.com/"
url: "https://www.zendesk.com/"
- name: "Jetstack"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be inserted alphabetically into the list.

@ericvn ericvn dismissed their stale review May 25, 2021 13:49

Should have been a comment

@ericvn
Copy link
Contributor

ericvn commented May 25, 2021

You also need to satisfy the CLA bot.

@ericvn
Copy link
Contributor

ericvn commented May 27, 2021

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 27, 2021
@craigbox
Copy link
Contributor

craigbox commented Jun 1, 2021

You should actually be adding yourself as a "professional services" provider.

@craigbox
Copy link
Contributor

bump: we'd like to merge this, but please make the changes to move to the pro_services section!

Moved Jetstack to "pro_services" section and added "description" and "details".
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 6, 2021
@istio-testing
Copy link
Contributor

@massaox: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2021
@google-cla
Copy link

google-cla bot commented Jul 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Removed Jetstack from "users" section.
@google-cla
Copy link

google-cla bot commented Jul 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@craigbox
Copy link
Contributor

craigbox commented Jul 6, 2021

Thanks; now you'll need to rebase (and sign the CLA.)

@craigbox
Copy link
Contributor

craigbox commented Jul 6, 2021

/retest

@istio-testing
Copy link
Contributor

@massaox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_istio.io 89a271b link /test gencheck_istio.io
lint_istio.io 89a271b link /test lint_istio.io
update-ref-docs-dry-run_istio.io 89a271b link /test update-ref-docs-dry-run_istio.io
doc.test.profile_demo_istio.io 89a271b link true /test doc.test.profile_demo
doc.test.profile_none_istio.io 89a271b link true /test doc.test.profile_none
doc.test.profile_default_istio.io 89a271b link true /test doc.test.profile_default
doc.test.multicluster_istio.io 89a271b link true /test doc.test.multicluster
doc.test.profile_minimal_istio.io 89a271b link true /test doc.test.profile_minimal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn
Copy link
Contributor

ericvn commented Mar 3, 2023

PR seems to be abandoned. Please reopen/rebase and fix the CLA if you want this considered again.

@ericvn ericvn closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. kind/docs needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants