Update readme for istio install #490
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
istio-testing
added
the
size/M
richardwxn
changed the title
istio-testing
removed
the
do-not-merge/work-in-progress
richardwxn
force-pushed
the
update-install-readme
branch
from
52feb76 to
485e0ac
Compare
| if [[ -n "${MIXERLESS}" ]]; then | ||
| kubectl -n istio-system apply -f https://raw.githubusercontent.com/istio/proxy/master/extensions/stats/testdata/istio/metadata-exchange_filter.yaml | ||
| kubectl -n istio-system apply -f https://raw.githubusercontent.com/istio/proxy/master/extensions/stats/testdata/istio/stats_filter.yaml | ||
| kubectl -n istio-system apply -f https://raw.githubusercontent.com/istio/istio/master/tests/integration/telemetry/stats/prometheus/testdata/metadata_exchange_filter.yaml |
There was a problem hiding this comment.
As we know these are version sensitive now. Is this going to work with both master and 1.4 of tools?
There was a problem hiding this comment.
this is legacy part now, I would remove it
|
|
||
| release="${1:?"release"}" | ||
|
|
||
| if [[ "${release}" == *-latest ]];then |
There was a problem hiding this comment.
-dev is similarly resolved some place else. Can you check if it done in one of the other files?
There was a problem hiding this comment.
yes, it is resolved in other PR already, would update accordingly
istio-testing
added
the
needs-rebase
|
@richardwxn: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@richardwxn Just trying to go back and clean up some older PRs. What should we do with these changes? Rebase and get them in? I think #828 and #1012 overlap on some of the files. |
|
@richardwxn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
The readme looks a bit outdated also it is confusing regarding the usage between ./setup_istio.sh and ./setup_istio_release.sh, trying to 1. reorganize it. 2. update the deprecated part 3. encourage to use ./setup_istio_release.sh across.
can you help take a look? @howardjohn