additional-content-unittests #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyR1oN
requested changes
Feb 7, 2023
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
...AdditionalContent/AdditionalContentTests/SubtitleTests/GetAllSubtitlesRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...iatRTests/AdditionalContent/AdditionalContentTests/TagTests/GetAllTagsRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...iatRTests/AdditionalContent/AdditionalContentTests/TagTests/GetAllTagsRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...iatRTests/AdditionalContent/AdditionalContentTests/TagTests/GetTagByIdRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...RTests/AdditionalContent/AdditionalContentTests/TagTests/GetTagByTitleRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
changed by request.
LanchevychMaxym
requested changes
Feb 8, 2023
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
An answer for the previous change request. Changed naming and moved setups to private methods.
Tysyatsky
reviewed
Feb 9, 2023
Contributor
Tysyatsky
left a comment
Tysyatsky
left a comment
There was a problem hiding this comment.
On my humble opinion, it isn't critical to change, but it will make your tests cleaner and more straight forward.
...AdditionalContent/AdditionalContentTests/SubtitleTests/GetAllSubtitlesRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Show resolved
Hide resolved
...alContent/AdditionalContentTests/CoordinateTests/GetCoordinatesByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+35
to
+38
| Id = 2, | ||
| Status = SubtitleStatus.Illustrator, | ||
| StreetcodeId = 1 | ||
| } |
Contributor
There was a problem hiding this comment.
same here, use a constant
Contributor
Author
There was a problem hiding this comment.
Even in GetAll? It will be used once, is it really mandatory?
...AdditionalContent/AdditionalContentTests/SubtitleTests/GetSubtitleByIdRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...AdditionalContent/AdditionalContentTests/SubtitleTests/GetSubtitleByIdRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...RTests/AdditionalContent/AdditionalContentTests/TagTests/GetTagByTitleRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...RTests/AdditionalContent/AdditionalContentTests/TagTests/GetTagByTitleRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
...Tests/AdditionalContent/AdditionalContentTests/TagTests/GetTagsByStreetcodeIdHandlerTests.cs
Outdated
Show resolved
Hide resolved
Followed Natalia's advices
Kasterov
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST