Streetcode art&text unit tests #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chynchenko
requested review from
EyR1oN,
Kasterov,
Katerix,
Kotusyk,
LanchevychMaxym,
NadiaKishchuk and
Tatiana2424
Katerix
requested changes
Feb 9, 2023
|
|
||
| [Theory] | ||
| [InlineData(1)] | ||
| public async Task GetStreetcodeArtByStreetcodeId_ReturnsSuccesfullyStreetcodeArt(int streetcodeId) |
Contributor
There was a problem hiding this comment.
move setup's to private method's. don't repeat yourself)
| It.IsAny<Func<IQueryable<StreetcodeArt>, IIncludableQueryable<StreetcodeArt, object>>>())) | ||
| .ReturnsAsync(GetStreetcodeArtsList()); | ||
|
|
||
| mockMapper.Setup(x => x.Map<IEnumerable<StreetcodeArtDTO>>(It.IsAny<IEnumerable<object>>())).Returns(GetStreetcodeArtDTOList()); |
|
|
||
| Assert.Multiple( | ||
| () => Assert.NotNull(result), | ||
| () => Assert.True(result.IsSuccess)); |
Contributor
There was a problem hiding this comment.
As for me these checks are useless. If result is not null (first assert) that the result is obviously successful. Maybe it is better to check the type of result.Value. You can also check if the element was really deleted
Streetcode/Streetcode.XUnitTest/MediatRTests/StreetcodeTests/TextTests/DeleteTextTest.cs
Show resolved
Hide resolved
| .ReturnsAsync(testTexts); | ||
|
|
||
| repository.Setup(repo => repo.TextRepository.GetAllAsync(null, null)).ReturnsAsync(testTextsList); | ||
|
|
Contributor
There was a problem hiding this comment.
why two repository setups?? the last hides the first one. Also move them to private methods)
Streetcode/Streetcode.XUnitTest/MediatRTests/StreetcodeTests/TextTests/GetAllTextsTest.cs
Show resolved
Hide resolved
Streetcode/Streetcode.XUnitTest/MediatRTests/StreetcodeTests/TextTests/GetAllTextsTest.cs
Show resolved
Hide resolved
| var result = await handler.Handle(new GetTextByIdQuery(2), CancellationToken.None); | ||
|
|
||
| Assert.NotNull(result); | ||
| Assert.True(result.IsSuccess); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST