Skip to content

endpoints for main card, timelines, tags and partners #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NadiaKishchuk merged 12 commits into from
Mar 28, 2023
Merged

endpoints for main card, timelines, tags and partners #143

NadiaKishchuk merged 12 commits into from
Mar 28, 2023

Conversation

@NadiaKishchuk
Copy link
Contributor

@NadiaKishchuk NadiaKishchuk commented Mar 19, 2023

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@NadiaKishchuk NadiaKishchuk requested a review from a team March 19, 2023 18:56
Kasterov
Kasterov reviewed Mar 28, 2023
View reviewed changes
Streetcode/Streetcode.BLL/DTO/Partners/CreatePartnerDTO.cs Outdated
public string TargetUrl { get; set; }
public int LogoId { get; set; }
public string? UrlTitle { get; set; }
public string LogoBase64 { get; set; }
Copy link
Contributor

@Kasterov Kasterov Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field is named as if the base64 format is stored here, but isn't it? Is there only a name?

Copy link
Contributor Author

@NadiaKishchuk NadiaKishchuk Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nowhere used now
it was created because we thought the image would be sent with the entity, but as you know, it is not, so it needs to be removed. Thanks)

Kasterov
Kasterov approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Kasterov Kasterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NadiaKishchuk
remove unncessary code
418ef58 
for seeding image in partner create
@NadiaKishchuk NadiaKishchuk merged commit 48bda13 into newFixed Mar 28, 2023
Kotusyk added a commit that referenced this pull request Mar 29, 2023
@Kotusyk
Revert "Merge pull request #143 from ita-social-projects/historicalCo…
ee4df18 
…ntext"

This reverts commit 48bda13, reversing
changes made to 563ed75.
Kotusyk added a commit that referenced this pull request Mar 29, 2023
@Kotusyk
Revert "Revert "Merge pull request #143 from ita-social-projects/hist…
75f107f 
…oricalContext""

This reverts commit ee4df18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tysyatsky Tysyatsky Tysyatsky approved these changes

@Kasterov Kasterov Kasterov approved these changes

Assignees

@NadiaKishchuk NadiaKishchuk

@Kasterov Kasterov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NadiaKishchuk @Tysyatsky @Kasterov